Some updates #8
Open
Some updates #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for when the coordinates are read in from an external source and contain leading or trailing space, which would otherwise result in an empty coordinate.
- we need the test kmls in the repository to run tests
This update still allows the old way of setting a single inner bounday via equals: polygon.inner_boundary_is = LinearRing.new(...) Is adds support to assign as array: polygon.inner_boundary_is = [ LinearRing.new(...), LinearRing.new(...) ] Or add to the existing array: polygon.inner_boundary_is << LinearRing.new(...) polygon.inner_boundary_is << LinearRing.new(...) I have added a test for this
This allows you to loop over the features in the KMLFile in the same way you loop over features in containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a collection of a few small updates for ruby_kml:
Hope they seem ok!
Jeff