fix for #37 #38
Open
fix for #37 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UIViewController
schmidyy
reviewed
May 3, 2022
Owner
schmidyy
left a comment
schmidyy
left a comment
There was a problem hiding this comment.
Thanks for the contributions! I left one small comment :)
| if let tabBar = loaf.sender?.parent as? UITabBarController{ | ||
| if let tabBar = loaf.sender?.parent as? UITabBarController { | ||
| containerInsets.bottom += tabBar.tabBar.frame.height | ||
| } else if let tabBar = loaf.sender?.parent?.parent as? UITabBarController { |
Owner
There was a problem hiding this comment.
I wonder if we should also check if the loaf.sender?.parent is a UINavigationController here, because I worry that the "parent's parent" might be a screen that is hidden from the current view. How does this look?
Suggested change
| } else if let tabBar = loaf.sender?.parent?.parent as? UITabBarController { | |
| } else if let navController = loaf.sender?.parent as? UINavigationController, let tabBar = navController.parent as? UITabBarController { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks if parent or parent is UITabBarController. resolves #37