Adding center display location #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hayd25
commented
Jul 8, 2022
| case .top: | ||
| dismissedFrame.origin.y = -size.height - 60 | ||
| case .bottom: | ||
| dismissedFrame.origin.y = controller.view.bounds.height + 60 |
Author
There was a problem hiding this comment.
Note: for the bottom being the controller height + 60, I wondered if maybe it was meant to be just size.height + 60? That way it will animate up from 60 below its final bottom coordinate rather than shoot up from far below the screen.
Thanks again for the well written library!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to ability to display a Loaf center screen, so made a pull request, feel free to discard if you don't feel it will be useful to anyone else.
Thanks for the great repo, you have done a great job and it's come in very useful!