-
Notifications
You must be signed in to change notification settings - Fork 103
chore(ci): use macos-15-intel for x86 wheel building and testing #3720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I see x86 macos wheels under https://pypi.org/project/awkward-cpp/50/#files |
|
Oh right, there hasn't been an |
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3720 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
Thanks to Henry for pointing out that |
|
@ariostas - it looks like the ci runner does not come with llvm? |
|
@ianna I think we'll have to restrict to numba 0.62 for macOS x86 because both numba and llvmlite stopped shipping wheels for it. |
Yes. Or maybe it is time to drop macOS x86? |
|
Hmm yeah, I guess we should do that soon. Maybe for now we can give up on doing the full testing and just test with the minimal requirements. Is there a plan for a minor version bump soon? We probably should schedule the drop of support to go with that |
Edit: No I'm stupid. It would try to compile from source. |
I think for that, it's probably good to see what the scientific python community is doing in general. |
|
Hi @ariostas - I think, just |
|
@ianna this is ready now. The GPU tests are failing, but that's due to the cudf issue. Also, you'll need to mark some of the tests are not required since it's not longer going to test on all versions of Python. |
ianna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariostas - Great! Thanks for making it happen. Please go ahead and merge it. Thanks!
The wheels that are built in
macos-14andmacos-15are identical (since they are both arm64), so I just switched to using `macos-latest.This closes #3718 which was failing since there were duplicate wheels.
Also, I guess we quietly dropped support for x86 macs, but no one has complained, so I guess it's fine.