Skip to content

Conversation

@jonswar
Copy link

@jonswar jonswar commented May 22, 2015

Add short-circuit return in Wrong::FailureMessage::wrap_and_indent, to prevent infinite loop in environments where the width of Wrong::Terminal.size is incorrectly set to 0 (or <=6).

The infinite loop can be reproduced with:

#!/usr/bin/env ruby
require 'wrong/assert'
include Wrong::Assert
ENV['COLUMNS'] = '6'
f = "aaaaa"
assert { f.nil? }

Yes, most terminal widths shouldn't be set to 0, but in my case a combination of iterm + emacs caused it to be so.

…o prevent infinite loop in environments where the width of Wrong::Terminal.size is incorrectly set to 0 (or <=6)
@kaorukobo
Copy link

Thank you for the great library and jonswar's helpful patch.
On my RubyMine's runner, it caused the same infinite loop and jonswar's patch solved the problem.
I hope this PR will be accepted and the gem will be bumped to 0.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants