Skip to content

Conversation

@Erikhu1
Copy link

@Erikhu1 Erikhu1 commented Dec 3, 2025

Worked through and filled out checklists and evidences for all TAs associated with TT-Expectations:

@Erikhu1 Erikhu1 changed the title Luca fgr complete tt expectations context rebased Worked through checklists and evidences for TT-EXPECTATIONS Dec 3, 2025
@github-actions github-actions bot added the L label Dec 3, 2025
@coveralls
Copy link

coveralls commented Dec 3, 2025

Coverage Status

coverage: 99.186%. remained the same
when pulling 8339e5d on LucaFgr-Complete_TT_EXPECTATIONS_CONTEXT_rebased
into 2ddacb3 on main.

@halnasri halnasri self-requested a review December 3, 2025 12:47
@LucaFue LucaFue marked this pull request as draft December 3, 2025 13:03
@github-actions github-actions bot removed the L label Dec 4, 2025
@LucaFue LucaFue self-assigned this Dec 4, 2025
@github-actions github-actions bot added L and removed L labels Dec 4, 2025
@github-actions github-actions bot added L and removed L labels Dec 10, 2025
@github-actions github-actions bot added the L label Dec 15, 2025
@github-actions github-actions bot added L and removed L labels Jan 9, 2026
@github-actions github-actions bot added the L label Jan 12, 2026
@github-actions github-actions bot removed the L label Jan 13, 2026
@github-actions github-actions bot added the L label Jan 13, 2026
- **Answer**: The nlohmann/json library does not have any external dependencies apart from the testing pipeline, so there are no dependencies that could possibly affect the Expectations.
- Are input analysis findings from components, tools, and data considered in relation to Expectations?
- **Answer**:
- **Answer**: For components, there is no input analysis as the nlohmann/json library has no external components (see JLS-34). For Tools, a tool assessment is provided via JLS-50. In addition, the only data provided to the nlohmann/json library is the input data when using the libraries' functionality, as well as the test data taken from [here](https://github.com/nlohmann/json_test_data).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still haven't mentioned anything about input analysis findings for the json_test_data and whether it was considered for the Expectations

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adapted the answer.

Generally, I would advise against a full input analysis of json_test_data because it aggregates large, well-known, independently curated JSON test suites that are already specifically designed to cover malformed inputs, edge cases, and realistic usage, so re-classifying every file would be a high-effort, low-benefit exercise that would also be hard to keep up to date as upstream data evolves. In our context, we already combine these corpora with nlohmann/json’s own tests and fuzzing and achieve very high coverage.

- **Answer**: No downstream consumers exist yet to validate this. However, the AOUs are structured with the intent to guide downstream consumers in extending existing Statements.
- Do they provide clear guidance for upstreams on reusing components with
well-defined claims?
- **Answer**:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this empty?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered it.

@github-actions github-actions bot removed the L label Jan 14, 2026
@github-actions github-actions bot added L and removed L labels Jan 14, 2026
@github-actions github-actions bot added the L label Jan 16, 2026
@github-actions github-actions bot removed the L label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants