halnasri-Resolve_TT_CONFIDENCE_Feedback #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

halnasri merged 29 commits into main from halnasri-Resolve_TT_CONFIDENCE_Feedback

Nov 25, 2025

halnasri commented Nov 18, 2025

resolving the review comments of aschemmel and erik and luca (see score-json#132 and score-json#118)

github-actions bot added the L label

halnasri requested review from Erikhu1 and LucaFgr

November 18, 2025 09:38

coveralls commented Nov 18, 2025 •

edited

Loading

coverage: 99.186%. remained the same
when pulling 84e6ef3 on halnasri-Resolve_TT_CONFIDENCE_Feedback
into 7233c86 on main.

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-09.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-13.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-36.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-36.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-37.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-40.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-41.md Show resolved Hide resolved

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-42.md Outdated Show resolved Hide resolved

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-43.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-37.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-41.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-42.md Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-41.md Outdated Show resolved Hide resolved

halnasri force-pushed the halnasri-Resolve_TT_CONFIDENCE_Feedback branch from d1fb2f0 to b0071a2 Compare

November 18, 2025 15:55

github-actions bot removed the L label

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Outdated Show resolved Hide resolved

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-41.md Outdated Show resolved Hide resolved

github-actions bot added the L label

Erikhu1 previously approved these changes

View reviewed changes

Erikhu1 left a comment •

edited

Loading

Good job! Approved, but please wait with the merge until the ongoing CI execution in main finishes

EDIT: Please rebase it to main and add your answers to the checklists and evidence lists in the context file first

Erikhu1 self-requested a review

November 19, 2025 15:59

halnasri and others added 11 commits

November 19, 2025 16:10


          adding new statements to TA-METHODOLOGIES and fixing statements from …

735c953

…TA-CONFIDENCE


          added references to JLS 40 and 42

b2c9078


          Update TSF/trustable/statements/JLS-43.md

17c688e

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Update TSF/trustable/statements/JLS-42.md

2ca6fde

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Update TSF/trustable/statements/JLS-37.md

c427ef3

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Update TSF/trustable/statements/JLS-09.md

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Update TSF/trustable/statements/JLS-08.md

d492dcd

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          changed JLS08 to be more clear

d34e62d


          corrected the statement of JLS-37

6516e0c


          corrected the statement of JLS-41

eed921c


          corrected the file path in JLS-36

ac4709b

halnasri force-pushed the halnasri-Resolve_TT_CONFIDENCE_Feedback branch from 9f19d91 to 0bf193a Compare

November 24, 2025 11:18

github-actions bot added the L label

Erikhu1 reviewed

View reviewed changes

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-CONFIDENCE_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-CONFIDENCE_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/statements/JLS-13.md Outdated Show resolved Hide resolved

Erikhu1 dismissed their stale review

November 24, 2025 14:48

github-actions bot removed the L label

LucaFgr reviewed

View reviewed changes

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

LucaFgr reviewed

View reviewed changes

TSF/trustable/statements/JLS-36.md Outdated Show resolved Hide resolved


          fixed TA-CONFIDENCE

5233b5c

github-actions bot added the L label

halnasri added 3 commits

November 25, 2025 08:36


          fixed TA-METHODOLOGIES

c7852e1

1b64c60


          corrected JLS-13

4c8d15f

LucaFgr reviewed

View reviewed changes

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved


          typo

b4d2d54

Erikhu1 reviewed

View reviewed changes

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

TSF/trustable/assertions/TA-METHODOLOGIES_CONTEXT.md Outdated Show resolved Hide resolved

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Show resolved Hide resolved


          added new reference to JLS-08

697180f

halnasri force-pushed the halnasri-Resolve_TT_CONFIDENCE_Feedback branch from 779789e to 697180f Compare

November 25, 2025 10:27


          edited one answer of TA-Methodologies context file

0ccf8eb

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Outdated Show resolved Hide resolved

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Outdated Show resolved Hide resolved

halnasri and others added 2 commits

November 25, 2025 14:03


          Update TSF/trustable/statements/JLS-08.md

4f61b66

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Update TSF/trustable/statements/JLS-08.md

6e16dfd

Co-authored-by: Erik Hu <erik.hu@d-fine.com>
Signed-off-by: halnasri <hatem.alnasri@d-fine.com>

Erikhu1 reviewed

View reviewed changes

TSF/trustable/statements/JLS-08.md Show resolved Hide resolved

halnasri added 2 commits

November 25, 2025 14:31


          Add https evidence

6490bb9

Added evidence configuration for response time and URL.

Signed-off-by: halnasri <hatem.alnasri@d-fine.com>


          Fix formatting in JLS-08.md

84e6ef3

Signed-off-by: halnasri <hatem.alnasri@d-fine.com>

Erikhu1 approved these changes

View reviewed changes

Erikhu1 left a comment

Well done! Looks good to me.

LucaFgr approved these changes

View reviewed changes

halnasri merged commit 6fbfaf3 into main

85 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L