Open
Conversation
Rupeshiya
reviewed
Dec 25, 2019
Rupeshiya
left a comment
Rupeshiya
left a comment
There was a problem hiding this comment.
@thivatm Just a little suggestion, You can write the checkUrl function in a shared service so that it can be used everywhere to validate the URL.
It will also improve the quality of code, so use DRY.
Otherwise everything else looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
Changes proposed in the pull request
Added URL validations to the URL
Impact
The URLs will be checked whether they are valid before submitting the form
Other information
N/A
Check if you have done the following before creating the PR
When the URL is invalid
If the user tries to submit the invalid URL
When the URL is valid
