Adjust Line Height for Footnote Block #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmiegit
approved these changes
Feb 22, 2025
Member
|
Add screenshots of the change for bibliography items and it's good to merge imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block of footnotes at the bottom of the page does not wrap the footnotes into either a
<li>or<p>element, causing it to not inherit theline-height: 1.5that paragraphs get by default. This applies that line-height argument to both the footnotes at the bottom of the page and the to the footnote blocks themselves, so it is not compressed.Footnotes of SCP-3477 at present, in which footnote two gets the line-spacing because of the multiple paragraphs in the footnote, but in which the other footnotes do not have the line spacing.
Footnotes of SCP-3477 after line-spacing applied to
.footnote-footer.Current implementation of a footnote hovertip.
Footnote after change.