fix: api/game/room-terrain returning encoded terrain data in all cases #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As rooms generated via the `map.generateRoom` CLI command would never set `type: "terrain"`, the check for decoding those would always fail, leading to encoded terrain being returned whether the `&encoded` param was set or not. Fix the issue by always decoding if a string `terrain` key is found on a single-result return, but for consistency, also fix `generateRoom` to add that `type` property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As rooms generated via the
map.generateRoomCLI command would never settype: "terrain", the check for decoding those would always fail, leading to encoded terrain being returned whether the&encodedparam was set or not.Fix the issue by always decoding if a string
terrainkey is found on a single-result return, but for consistency, also fixgenerateRoomto add thattypeproperty.