-
Notifications
You must be signed in to change notification settings - Fork 95
Add confirm dialog for translation source language #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Changes are looking good so far, @catreedle :) Taking a moment to also update the docstrings so that we're using consistent spacing, punctuation and capitalization 😊 I'll finalize this later. |
thank you! I've added a few things :) |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Implementation is really wonderful, @catreedle 😊 Thanks so much for the hard work in finalizing this so quickly! Your input on this process has been invaluable, and the execution is exactly what we need :)
|
@catreedle, would you be able to fix the merge conflict and then move the file back to the directory you'd moved it to? |
sure! |
|
Thanks so much for fixing the conflicts, @catreedle! 😊 |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Related issue