Skip to content

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

  • This PR adds ConfirmationDialog and use it in DataDownloadScreen to show tooltip after user clicks on Download language data.
  • Moves DownloadState from DownloadDataButtonComp into a ViewModel so it is accessible for Download screen and ConfirmationDialog.
  • Handles action on clicking on the button of the confirmation tooltip.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Changes are looking good so far, @catreedle :) Taking a moment to also update the docstrings so that we're using consistent spacing, punctuation and capitalization 😊 I'll finalize this later.

@catreedle
Copy link
Collaborator Author

Changes are looking good so far, @catreedle :) Taking a moment to also update the docstrings so that we're using consistent spacing, punctuation and capitalization 😊 I'll finalize this later.

thank you! I've added a few things :)

@andrewtavis andrewtavis self-requested a review December 25, 2025 16:24
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Implementation is really wonderful, @catreedle 😊 Thanks so much for the hard work in finalizing this so quickly! Your input on this process has been invaluable, and the execution is exactly what we need :)

@andrewtavis
Copy link
Member

@catreedle, would you be able to fix the merge conflict and then move the file back to the directory you'd moved it to?

@catreedle
Copy link
Collaborator Author

@catreedle, would you be able to fix the merge conflict and then move the file back to the directory you'd moved it to?

sure!

@andrewtavis
Copy link
Member

Thanks so much for fixing the conflicts, @catreedle! 😊

@andrewtavis andrewtavis merged commit 0c609bd into scribe-org:main Dec 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants