Skip to content

Conversation

@sf-cuestas
Copy link
Contributor

@sf-cuestas sf-cuestas commented Dec 23, 2025

Contributor checklist


Description

padding added for the SwitchableItemComp to separate a little the text and the toggle

image

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@sf-cuestas sf-cuestas changed the title space between the toggle and the text added space between the toggle and the text Dec 23, 2025
@andrewtavis
Copy link
Member

Thanks so much for the quick PR and for including a screenshot, @sf-cuestas :) We'll review and try to bring this in sook 😊

@andrewtavis andrewtavis self-requested a review December 25, 2025 16:27
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Exactly what we were looking for, @sf-cuestas! Really appreciate your quick work on this issue :) Please let us know if there's something else of interest for you!

@andrewtavis andrewtavis merged commit 1bceeb3 into scribe-org:main Dec 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase space between text and toggle on toggle menu options

2 participants