Skip to content

Conversation

@catreedle
Copy link
Collaborator

Contributor checklist


Description

Added values-in folder to support legacy Indonesian language code. Android uses both "in" (legacy) and "id" (modern) codes for Indonesian, but translations were only in values-id.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

question: @catreedle, how do we think we can achieve this in a more sustainable way? I think that this change should almost certainly go into Scribe-i18n. Is what you're saying that the contents should be the same for each file? Maybe we can localize the id file and then copy it over when we run the Python scripts? If in should be different than id, then how about we add a new language into Scribe-i18n? :)

@catreedle
Copy link
Collaborator Author

question: @catreedle, how do we think we can achieve this in a more sustainable way? I think that this change should almost certainly go into Scribe-i18n. Is what you're saying that the contents should be the same for each file? Maybe we can localize the id file and then copy it over when we run the Python scripts? If in should be different than id, then how about we add a new language into Scribe-i18n? :)

yeah. The contents should be the same. I think it makes sense to automate it with Python scripts.

@andrewtavis
Copy link
Member

andrewtavis commented Dec 26, 2025

Mapping out the work left for this issue here, @catreedle:

  • Finalize the four scripts (just JSON to strings conversion script) in Scribe-i18n such that in and id are synced by them
    • Maybe best via a dictionary that as of now just maps id to in such that we can add more key value pairs later
    • If someone localizes in on Weblate, then we can copy it to id (in isn't in Weblate)
  • Move your change in this PR over to Scribe-i18n
  • Do the Android conversion script to generate the JSON for in
  • Update Scribe-i18n and we'll close Allow for locale copies in scripts Scribe-i18n#99
  • Update Scribe-i18n within this branch and then we'll bring in the latest version to close this PR 😊

@andrewtavis
Copy link
Member

Hey @catreedle 👋 Let's close this one as #528 will close #515 once you bring the changes from scribe-org/Scribe-i18n#99 into #528 😊

@andrewtavis andrewtavis mentioned this pull request Dec 27, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants