-
Notifications
You must be signed in to change notification settings - Fork 103
feat:add a new storyboard, info.plist and target #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add a new storyboard, info.plist and target #586
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@angrezichatterbox, do you have an idea of what the issue with the CI tests is? |
|
Thanks for opening the PR, btw! Amazing that we have progress on both projects now 😊 |
I will look into it and fix it later today. |
Does this mean that the current iOS repository uses Scribe-i18n commit which no longer exists in Scribe-i18n. |
|
Thanks for looking into the error, @angrezichatterbox! What ended up being the issue with that error? Would be good to discuss in the PR so we can reference the solution later 😊 |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Absolutely amazing, @angrezichatterbox! So cool to see both apps together within one repo. So glad that we went this route 😊 Thanks for your research and efforts! Let's definitely discuss this with the community during the sync.
The commit was no longer present was what I understood so I removed the submodule and added it again with the current one. I hope that doesn't break anything. |
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
The PR adds the conjugate application and the necessary things needed to run an additional target. I have currently copied the existing storyboard of the app to be displayed for the conjugate app.
Related issue