-
Notifications
You must be signed in to change notification settings - Fork 699
Fix stacked_violin plot bug #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`num_rows` was incorrectly calculated when `swap_axes=False`.
|
Thank you for this! Unfortunately, it breaks the tests. It's such a small change, but I guess @fidelram had something in mind when setting it the way he did... |
|
I’ll have another look. But it doesn’t work the way it is now either |
|
@fidelram Sounds good! |
|
@outlace Curiously, your change causes an error. Without your change I can run the tests correctly without a problem. I remember that I fixed a bug similar to this one that was recently integrated into master (see https://github.com/theislab/scanpy/pull/425/files#diff-b5175ed1415cdbf853646e523cbe8ae0L902). Could it be that you didn't have the latest pull from scanpy and that was causing the error? |
|
Possible, I will try pulling the latest master and see if I still get the problem |
|
@outlace do you think I can close this PR? |
|
yes 405 got fixed. The code was moved to |
|
Great, thanks! |
num_rowswas incorrectly calculated whenswap_axes=Falsein thestacked_violinplot. This fixes issue #405