Skip to content

Conversation

@outlace
Copy link

@outlace outlace commented Mar 10, 2019

num_rows was incorrectly calculated when swap_axes=False in the stacked_violin plot. This fixes issue #405

`num_rows` was incorrectly calculated when `swap_axes=False`.
@falexwolf
Copy link
Member

Thank you for this! Unfortunately, it breaks the tests. It's such a small change, but I guess @fidelram had something in mind when setting it the way he did...

@outlace
Copy link
Author

outlace commented Mar 10, 2019

I’ll have another look. But it doesn’t work the way it is now either

@fidelram
Copy link
Collaborator

@outlace I will check the problem with the test and integrate your changes in a new PR that addresses #512 and #524 if this is OK with you.

@outlace
Copy link
Author

outlace commented Mar 11, 2019

@fidelram Sounds good!

@fidelram
Copy link
Collaborator

@outlace Curiously, your change causes an error. Without your change I can run the tests correctly without a problem. I remember that I fixed a bug similar to this one that was recently integrated into master (see https://github.com/theislab/scanpy/pull/425/files#diff-b5175ed1415cdbf853646e523cbe8ae0L902). Could it be that you didn't have the latest pull from scanpy and that was causing the error?

@outlace
Copy link
Author

outlace commented Mar 11, 2019

Possible, I will try pulling the latest master and see if I still get the problem

@fidelram
Copy link
Collaborator

@outlace do you think I can close this PR?

@fidelram fidelram closed this Apr 8, 2019
@ivirshup
Copy link
Member

@fidelram, did that PR happen? I assume #405 got fixed but am not actually sure.

@fidelram
Copy link
Collaborator

yes 405 got fixed. The code was moved to _stacked_violin.py

@ivirshup ivirshup linked an issue Jan 27, 2021 that may be closed by this pull request
@ivirshup
Copy link
Member

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sc.pl.stacked_violin: IndexError, list index out of range

4 participants