Skip to content

Conversation

@fidelram
Copy link
Collaborator

This PR extends the original PR #512 by @gokceneraslan which adds the standard_scaling parameter to matrixplot.

I added the same functionality to dotplot, heatmap and stacked_violin.

Also, I integrated PR #524 by @sjfleming which adds a smallest_dot option to dotplot.

gokceneraslan and others added 13 commits March 3, 2019 14:59
Especially when we visualize raw counts, sometimes it's hard to see the differences between DEGs and other genes in the heatmap since one value can simply dominate the entire heatmap. I think we can add a scaling option to matrixplot, which squashes expression values between 0 and 1 to make markers more pronounced.
Allow greater customizability and visibility when using dotplot by allowing the user to set the smallest dot size.
@fidelram
Copy link
Collaborator Author

@falexwolf I updated the visualizations example notebook to reflect the changes: scverse/scanpy_usage#11

@falexwolf
Copy link
Member

Thank you! Shall we close @gokceneraslan PR then? Or do we need to merge it first and then merge this? Thanks for clarifying!

Regarding the examples: it's a bit unfortunate, but we migrated to https://github.com/theislab/scanpy-tutorials, and scanpy_usage is actually no longer used. I mentioned it before, but it might have got forgotten... Could you make a PR to scanpy-tutorials instead?

@gokceneraslan
Copy link
Collaborator

I think this PR has all the commits from two other PRs. Tricky to set up 😛 We can close mine.

@falexwolf
Copy link
Member

Cool! I'll merge this then. Thanks everybody!

@falexwolf falexwolf merged commit 74d3299 into scverse:master Mar 11, 2019
@fidelram
Copy link
Collaborator Author

@falexwolf Thanks. I will add the PR to scanpy-tutorials

awnimo pushed a commit to dpeerlab/scanpy that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants