Better dataset_id inference and minor fullres image fix #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
dataset_id is None, we now try to see ifdataset_id=""works, and, if not, try to infer the dataset_id.Previously, we directly inferred a (non-empty) dataset_id, which was therefore not working when
dataset_id="".I also made a small fix regarding the fullres image:
We had two variables
fullres_image_file_pathsandfullres_image_paths, causing an index error inload_image(path=fullres_image_file_paths[0], ...)whenfullres_image_pathsis used but notfullres_image_file_paths.FYI @LucaMarconato @grst