New pull request #14
New pull request #14
Conversation
python text_mining.py
Outdated
|
|
||
| >>> | ||
| """ | ||
| WORD = re.compile(r'\w+') |
There was a problem hiding this comment.
I would caution against using all caps for variable names because some programs will interpret them differently.
python text_mining.py
Outdated
| text_7 = 'Moby Dick by Melville.txt' | ||
|
|
||
|
|
||
| Text_similarity(text_1, text_2, text_3, text_4, text_5, text_6, text_7) |
There was a problem hiding this comment.
You should wrap these last lines of code in a final function and call that function at the end. On a more general note, Text_similarity works fine here because you're only dealing with 7 texts, but imagine if you had 20 or 100 texts to compare. You wouldn't want to write text_i over and over again. In the future, think about ways to make this more efficient.
|
Overall, good job! Your documentation is good and I made a few stylistic comments. Your ReadMe should contain instructions on how to run your program, include any libraries you installed and the installation instructions, indicate which file to run to get your results, and have a link to your reflection. |
I implemented all the annotations
|
This is the implementation of the notes made by Emily |
2 participants
This is the new pull request for the feedback