This repository was archived by the owner on Feb 28, 2022. It is now read-only.
patch for issues with already-merged classification branch#30
Open
patch for issues with already-merged classification branch#30
Conversation
Current coverage is 62.70%
@@ master #30 diff @@
==========================================
Files 7 7
Lines 498 378 -120
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 306 237 -69
+ Misses 192 141 -51
Partials 0 0
|
Member
|
Looks good. Here are a few more changes I would like:
|
trying to get psycopg2 on circleci
Member
|
Please address my previous comments. Once PR35 goes in, please merge those changes into this PR and get the functional and integration tests checked in previously working on CircleCI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed outstanding issues in 4.2-ml