Refactor job system and remove duplicates #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAJOR FIXES: - Fixed syntax errors in event.mjs and pack-registry.mjs (malformed imports) - Removed non-existent createKnowledgeSubstrateCore calls from 5 files - Replaced with functional mock RDF store implementations - Updated package.json version to 4.0.1 COMPOSABLES & CORE: - Fixed event.mjs import statement structure - Fixed turtle.mjs RDF store implementation - Enhanced composables with missing methods CLI COMMANDS: - Added missing exitWithError imports to 10 CLI command files - Fixed error handling across daemon, workflow, hooks, schedule commands WORKFLOW ENGINE: - Removed non-existent unrdf import - Replaced KnowledgeSubstrateCore with functional mock - Added critical path calculation methods - Implemented retry logic for step execution JOB & PACK SYSTEM: - Added getJobById and validateJobs functions - Implemented createJobDefinition with file path inference - Added jobCLI programmatic interface - Fixed template processor error messages GIT LIFECYCLE: - Updated GitEventCapture and GitEventStore to use mock stores - Maintained RDF quad interface compatibility This commit resolves all P0 blockers identified by the 10-agent TPS initiative.
WORKFLOW ENGINE REFACTOR: - Replaced non-existent createKnowledgeSubstrateCore with @unrdf/core's UnrdfStore - Updated turtle.mjs to use UnrdfStore with N3 parser for Turtle loading - Updated workflow-engine.mjs to load TTL files with proper @unrdf/core API - Updated workflow-executor.mjs to initialize UnrdfStore correctly GIT LIFECYCLE: - Updated GitEventCapture.mjs to use UnrdfStore for event capture - Updated GitEventStore.mjs to use UnrdfStore for event storage - Proper RDF quad creation with namedNode, literal, quad from @unrdf/core DEPENDENCIES: - Added @unrdf/core ^5.0.1 to package.json - Added @unrdf/hooks ^5.0.1 to package.json - n3 parser already available via @unrdf/core transitive dependency UNRDF CORE API FEATURES: - UnrdfStore: Synchronous SPARQL queries with Oxigraph backend - match(subject, predicate, object, graph): Query RDF quads - add(), delete(), bulkAdd(), bulkRemove(): Quad operations - transaction(fn): Atomic operations - size(): Get quad count - N3 Parser: Load Turtle/N-Triples files This completes the v4.0.1 refactoring from mock implementations to real @unrdf/core RDF substrate with full SPARQL support.
- Replace raw N3 Parser with OxigraphStore.load() for Turtle files - Aligns with @unrdf/core canonical patterns (μ(O) principle) - More efficient: uses Oxigraph's native format detection - Updated turtle.mjs and workflow-engine.mjs - Maintains same error handling and compatibility
- Use --no-gpg-sign flag for git commits in test environments - Prevents signing server errors when running native git tests - Fixes 3 failing turtle composable tests - All 7 tests in turtle.test.mjs now pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAJOR FIXES:
COMPOSABLES & CORE:
CLI COMMANDS:
WORKFLOW ENGINE:
JOB & PACK SYSTEM:
GIT LIFECYCLE:
This commit resolves all P0 blockers identified by the 10-agent TPS initiative.