Skip to content

Conversation

@zbrydon
Copy link
Contributor

@zbrydon zbrydon commented Dec 15, 2025

#159

service: are there any problems with this being e.g. aws-codedeploy-hook-BeforeAllowTraffic across all deployments?

I don't think so and think so 🤔
I lazily went with aws-codedeploy-hook because the handler and logger are shared between the hook functions and I think most of the value will still be driven from applicationName instead of service.

tier: should we configure e.g. tin at the payload level, or leave it to external (LogCentral) configuration?

I think setting it here is a good option because I am not sure we can safely assume that people have a sane LogCentral config 😅

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: 00de93c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zbrydon zbrydon marked this pull request as ready for review December 15, 2025 09:02
@zbrydon zbrydon requested a review from a team as a code owner December 15, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant