Fix: Prevent failed events from being dequeued#140
Closed
sebapastore wants to merge 1 commit intosegmentio:mainfrom
Closed
Fix: Prevent failed events from being dequeued#140sebapastore wants to merge 1 commit intosegmentio:mainfrom
sebapastore wants to merge 1 commit intosegmentio:mainfrom
Conversation
sebapastore
changed the title
sebapastore
force-pushed
the
fix/prevent-failed-events-dequeue
branch
from
d0d9f14 to
b2c5bcb
Compare
This was referenced May 23, 2025
Contributor
|
Hello @sebapastore , Thanks for your suggestions. We have created a single Pull Request #162 with your changes in this PR as well as PR #142 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
SegmentDestination, ensure that only events that were sent successfully are added to thesentEventslist. This allows failed events to remain in the queue and be retried in the next attempt.