Skip to content

fix: add sasl-secrets-manager-arn to shared opts #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petedannemann merged 2 commits into from
Mar 6, 2025
Merged

fix: add sasl-secrets-manager-arn to shared opts #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2c9652
fix: add sasl-secrets-manager-arn to shared opts
petedannemann Mar 6, 2025
1c8153d
persistentflags -> flags
petedannemann Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/topicctl/subcmd/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,4 +314,10 @@ func addSharedConfigOnlyFlags(cmd *cobra.Command, options *sharedOptions) {
os.Getenv("TOPICCTL_SASL_USERNAME"),
"SASL username if using SASL; will override value set in cluster config",
)
cmd.Flags().StringVar(
&options.saslSecretsManagerArn,
"sasl-secrets-manager-arn",
os.Getenv("TOPICCTL_SASL_SECRETS_MANAGER_ARN"),
"Secrets Manager ARN to use for credentials if using SASL; will override value set in cluster config",
)
}