Fix native build infrastructure for encryption tests #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a comprehensive test suite for PrivacyLRS encryption, demonstrating security findings from cryptographic analysis and providing regression testing for security fixes. Test Coverage (24 tests total): - Stream cipher counter synchronization (Finding #1 - CRITICAL) * 2 tests demonstrate desynchronization vulnerabilities * Tests fail as expected, validating the security finding - Key logging documentation (Finding #4 - HIGH) - Forward secrecy validation (Finding #7 - MEDIUM) - RNG quality checks (Finding #8 - MEDIUM) - ChaCha20 functionality verification (10 tests) - Integration tests with timer simulation (6 tests) Expected Test Results: - WITHOUT fixes: 2 tests FAIL (Finding #1), 22 tests PASS - AFTER Finding #1 fix: All 24 tests PASS Test Execution: cd src PLATFORMIO_BUILD_FLAGS="-DRegulatory_Domain_ISM_2400 -DUSE_ENCRYPTION" \ pio test -e native --filter test_encryption Files Added: - test/test_encryption/test_encryption.cpp (1540 lines) - test/test_encryption/README.md (comprehensive documentation) This is Phase 1 of the security improvement project. Phase 2 will implement fixes for the critical synchronization vulnerability.
Resolves build failures in native test environment that were blocking PR #18 validation. **Issue #1: Missing stdio.h header** - Added #include <cstdio> to test_encryption.cpp - Fixes printf() undeclared errors on line 1535-1536 **Issue #2: Undefined ICACHE_RAM_ATTR for native builds** - Added #include "targets.h" to encryption.h - Added TARGET_NATIVE case in targets.h to define ICACHE_RAM_ATTR as empty - Fixes "expected initializer before 'DecryptMsg'" errors **Test Results:** - Native build now succeeds (24 tests: 21 pass, 2 intentionally fail) - 2 failing tests demonstrate Finding #1 vulnerability (as expected) - All compilation errors resolved **Files Changed:** - src/test/test_encryption/test_encryption.cpp (+1 line) - src/include/encryption.h (+2 lines) - src/include/targets.h (+5 lines)
Resolved merge conflict in test_encryption.cpp (whitespace differences only). The files were functionally identical, used secure_01 version for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes native build failures in the encryption test suite that were blocking validation.
Issues Fixed
Issue #1: Missing stdio.h header ✅
printf() was not declared in this scope#include <cstdio>to test_encryption.cppIssue #2: Undefined ICACHE_RAM_ATTR for native builds ✅
expected initializer before 'DecryptMsg'#include "targets.h"to encryption.hTest Results
Native build now succeeds:
The 2 failing tests are expected:
test_single_packet_loss_desynctest_burst_packet_loss_exceeds_resyncThese demonstrate the counter synchronization vulnerability before fixes are applied.
Files Changed
src/test/test_encryption/test_encryption.cpp(+1 line)src/include/encryption.h(+2 lines)src/include/targets.h(+5 lines)Total: 3 files, 8 insertions, 1 deletion
Verification
Result: All compilation errors resolved, tests run successfully.
Impact
Developer
2025-12-02