fix for cmake version 2.8 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No new features
Not tested yet
But buttons are not working yet
but need to change the way the elements are allocated. Instead of allocating everything at the beginning, allocate on the go.
Taking into account when there is arrange of usages or a HID element, each should have its own SC element (at least if it is not an array)
The Hid components are part of the standard SDK with MSVC
and some tidying up
The install should be defined within SC, and not within the submodule, to allow variables like auxresourcesdir to be used without reassigning them
HID support for Windows and various additions towards HID in 3.8
|
The duplicate line "cmake_policy(SET CMP0048 OLD)" (line 3 and 6) in CMakeLists.txt is still in there. So it is not "a fix for cmake 2.8". Line 6 must go. Sorry. |
Remove duplicate line regarding cmp0048
Initialize the counter variable i to zero in hid_parse_input_report(), fixing a bug whereby a segfault can happen when the function is entered more than once.
tested in mingw- and VS-build
Fix counter bug in hid_parse_input_report()
Include windows.h to fix MinGW32 build, thanks sonoro1234
…reaks old headers build).
Build hidapi against latest mingw-w64 headers
Add FreeBSD compatibility
|
@sonoro1234 @sc3sc3 @bagong , is this repository still being maintained? If not, perhaps we should close this and focus dev work at supercollider/hidapi, which is 33 commits ahead. on a similar note, I have a PR there that I'd appreciate a second look at. |
cmake: bump to 3.0, use modern project() syntax
Caused issues by processing run loop at undesirable moments.
Undo "fix hidapi enumeration bug on OSX" - commit c43255b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt