Dockerfile.dev for development by WoZ · Pull Request #33 · sentry-extensions/cyclops

WoZ · 2017-10-03T17:00:53Z

Development and testing process should be unified. Docker is a good candidate.

Build the container:

$ docker build --rm -t cyclops:dev -f Dockerfile.dev .

Bootstrap the container:

$ docker run --rm -d --name=cyclops-dev -v $PWD:/opt/cyclops cyclops:dev

Run the container:

$ docker start cyclops-dev

Attach into the container:

$ docker exec -it cyclops-dev bash

Stop container:

$ docker stop cyclops-dev

Remove container:

$ docker rm -f cyclops-dev

Install dependencies and run tests (after start of container and login into it):

$ cd /opt/cyclops
$ pip install -e . -e .[mysql] -e .[tests]
$ CYCLOPS_TEST_DB_USER=sentry CYCLOPS_TEST_DB_PASS=sentry make tests

…support

index0h · 2017-10-04T12:03:00Z

Dockerfile.dev

+
+FROM mysql:5.7
+
+RUN apt-get update && apt-get install -y --no-install-recommends build-essential tcl curl wget vim python2.7 python3.4 python-pip python-dev python3-dev libssl-dev libcurl4-openssl-dev libmysqlclient-dev


Clear apt cache at the end of command

index0h · 2017-10-04T12:03:29Z

Dockerfile.dev

+
+RUN apt-get update && apt-get install -y --no-install-recommends build-essential tcl curl wget vim python2.7 python3.4 python-pip python-dev python3-dev libssl-dev libcurl4-openssl-dev libmysqlclient-dev
+
+RUN mkdir -p /tmp/redis-server


It's better to make redis build in single RUN instruction. No need to create huge file system layers, which you will not use

Is it possible to combine few RUN instructions?

nope. Any instructions like RUN, ENV, COPY... create new file system layer

index0h · 2017-10-04T12:04:22Z

Dockerfile.dev

+RUN update-alternatives --install /usr/bin/python python /usr/bin/python2.7 1
+RUN mkdir -p /opt/cyclops
+
+COPY docker/docker-entrypoint-dev.sh /usr/bin/docker-entrypoint.sh


Have you any plans to create another files, like docker-entrypoint-prod.sh?

index0h · 2017-10-04T12:05:32Z

Dockerfile.dev

+# Instructions:
+#
+#   Build the container:
+#     $ docker build --rm -t cyclops:dev -f Dockerfile.dev .


Push and image to docker hub!

Not related with this PR

index0h · 2017-10-04T12:06:21Z

docker/post-install-dev.sh

+mysql -usentry -psentry -e "CREATE DATABASE sentry;"
+mysql -usentry -psentry sentry < /opt/cyclops/tests/sentry_db.sql
+
+service mysql stop


For unification purpose. post install runs once but service mysql start runs on every run. I think that checking that mysql is running each time docker start calls is much worse than stop-start cycle on bootstrap phase.

index0h · 2017-10-04T12:09:43Z

Dockerfile.dev

+#   Bootstrap the container:
+#     $ docker run --rm -d --name=cyclops-dev -v $PWD:/opt/cyclops cyclops:dev
+#   Run the container:
+#     $ docker start cyclops-dev


You already have running container. Docker remove it on stop

So, you suggest remove --rm from docker run?

No I suggest single flow. If you use --rm - no need to write instructions like start

index0h · 2017-10-04T12:10:22Z

Dockerfile.dev

+#   Attach into the container:
+#     $ docker exec -it cyclops-dev bash
+#   Stop container:
+#     $ docker stop cyclops-dev


Remove this and next instructions, you already recommend once-running containers.

index0h · 2017-10-04T12:11:00Z

Dockerfile.dev

+#
+# NOTE: This should not be used in production!
+#
+# Instructions:


This information should be in README or CONTRIBUTING

index0h · 2017-10-04T12:12:12Z

Dockerfile.dev

@@ -0,0 +1,49 @@
+# cyclops dev environment


It's better to move your files to specific directory, for example
docker/work/Dockerfile
docker/work/root/usr/local/bin/docker-entrypoint.sh
docker/work/root/usr/local/bin/post-install.sh

Make no sense for small deployments like this one.

how about prod docker file? where it will be stored?

WoZ added 3 commits October 3, 2017 19:56

Dockerfile.dev for development

145b5b8

Dockerfile.dev for development. Blank lines.

4098eff

Merge remote-tracking branch 'remotes/origin/master' into docker-dev-…

660e839

…support

index0h reviewed Oct 4, 2017

View reviewed changes


		FROM mysql:5.7

		RUN apt-get update && apt-get install -y --no-install-recommends build-essential tcl curl wget vim python2.7 python3.4 python-pip python-dev python3-dev libssl-dev libcurl4-openssl-dev libmysqlclient-dev


		RUN apt-get update && apt-get install -y --no-install-recommends build-essential tcl curl wget vim python2.7 python3.4 python-pip python-dev python3-dev libssl-dev libcurl4-openssl-dev libmysqlclient-dev

		RUN mkdir -p /tmp/redis-server

Conversation

WoZ commented Oct 3, 2017

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

index0h Oct 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading

index0h Oct 4, 2017 •

edited

Loading