Add namespace to secret creation heredoc#492
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
IMO adding an explicit namespace is always a good idea. If you don't do that, it will either end up in the IIRC I had this discussion with docs awhile ago on another ticket and there was a deliberate decision to not include it (I dont recall the reason). I'll see if I can dig up the link. Edit: Here's the link: #133 |
When I followed the instructions, I did exactly this and it took me a hot minute to work it out. |
gwright99
left a comment
There was a problem hiding this comment.
As per my comment in the Conversation tab, this issue has been covered before and the resulting structure was a deliberate decision. Sticking to the sidelines and making no comment re: viability of this PR (despite my personal opinions).
|
Taking @gwright99's comments into account it would probably make sense to update this doc to better reflect the changes we made to the enterprise content last year. @adamrtalbot, would that work? The change is here: https://github.com/seqeralabs/docs/pull/133/files. |
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
|
Thanks for this, @adamrtalbot! I've implemented the suggested changes. Please could you give them a review and then I think we're good to merge. :) |
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
|
@adamrtalbot, I'm cleaning up our PR queue. Is this ready to merge? :) |
There was a problem hiding this comment.
🪄 Pre-commit formatting suggestions
You can apply each suggestion via the GitHub UI, add a comment containing the keyword fix formatting or set up pre-commit locally and commit again.
There was a problem hiding this comment.
🪄 Pre-commit formatting suggestions
You can apply each suggestion via the GitHub UI, add a comment containing the keyword fix formatting or set up pre-commit locally and commit again.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
The heredoc for creating a k8s token was missing a namespace, or at least it didn't match the rest of the docs that focus on the tower-nf namespace. This PR adds it so that it matches up.