Skip to content

Conversation

@tamaralogeecom
Copy link
Collaborator

@tamaralogeecom tamaralogeecom commented Nov 7, 2025

What is the goal?

  • Remove unused variables and parameters for rendering the WidgetSettingsForm.

References

How is it being implemented?

This pull request streamlines the onboarding widget settings flow by removing the use of the paymentMethods data throughout the onboarding process and the WidgetSettingsForm. Instead, the form now relies solely on allAvailablePaymentMethods, simplifying both data management and the form's logic. Additionally, it improves navigation after saving settings and cleans up some code and documentation.

Key changes:

Onboarding widget settings data flow:

  • Removed fetching and usage of paymentMethods in the onboarding widgets step; now only allAvailablePaymentMethods is fetched and passed to the form (OnboardingController.js, WidgetSettingsForm.js). [1] [2] [3] [4] [5]
  • Updated the WidgetSettingsForm data structure and related logic to eliminate references to paymentMethods, relying on allAvailablePaymentMethods for payment method data. [1] [2] [3] [4]

Navigation improvements:

  • Enhanced the navigation logic after saving widget settings during onboarding to handle promotional flows and settings more robustly.

Code and documentation cleanup:

  • Removed unused refreshForm function and cleaned up related code in WidgetSettingsForm.js.
  • Improved formatting in JSDoc comments for better readability in ValidationService.js. [1] [2]
  • Fixed minor formatting in StateController.js.

How is it tested?

  • Manual tests
    • Follow the README instructions for building the resources
    • Follow the README instructions for copying resources into the Shopify integration
    • Install the SeQura Marketing app in Shopify
    • Check the look and feel in the onboarding state
    • Check the look and feel in the configuration state

Tamara Vukovic added 2 commits November 7, 2025 16:30
ISSUE: LIS-72
Tamara Vukovic added 2 commits November 12, 2025 11:21
@mescalantea mescalantea merged commit d35614d into master Dec 9, 2025
4 checks passed
@mescalantea mescalantea deleted the feature/LIS-72-additional-work branch December 9, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants