Backport bugfix: incorrect empty check

[mescalantea]

What is the goal?

This pull request improves validation logic in the constructors for both the Category and OrderStatus domain models. The main change is ensuring that parameters consisting only of whitespace are now treated as empty, making the input validation more robust.

References

• Issue: TIJ-2884

How is it being implemented?

• Updated the Category constructor to use trim() when checking if id or name are empty, ensuring that strings containing only whitespace are considered invalid.
• Updated the OrderStatus constructor to use trim() for both id and name parameters, aligning the validation logic and preventing whitespace-only values.

How is it tested?

Manual tests

How is it going to be deployed?

Standard deployment

[Copilot]

Pull request overview

This pull request backports a bugfix to strengthen input validation in the Category and OrderStatus domain models by rejecting whitespace-only parameters. The changes update constructor validation to use trim() before checking for empty strings, preventing whitespace-only values from being accepted.

• Updated validation logic in both Category and OrderStatus constructors to treat whitespace-only strings as empty
• Replaced inconsistent empty checking methods (empty() vs === "") with a unified trim() === '' approach

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/BusinessLogic/Domain/OrderStatus/Models/OrderStatus.php	Updated constructor validation to use trim() for both id and name parameters, ensuring whitespace-only values are rejected
src/BusinessLogic/Domain/GeneralSettings/Models/Category.php	Updated constructor validation to use trim() for both id and name parameters, aligning with OrderStatus validation approach

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

suggestion (non-blocking): Consider adding test coverage for whitespace-only strings

The updated validation logic now rejects whitespace-only strings (e.g., ' '), but the existing tests in OrderStatusModelTest only cover completely empty strings ''. Adding test cases for whitespace-only inputs would ensure this bugfix is properly validated.

Example:

public function testWhitespaceOnlyOrderStatusId(): void
{
    $this->expectException(EmptyOrderStatusParameterException::class);
    new OrderStatus('   ', 'test');
}

[Copilot]

suggestion (non-blocking): Consider adding test coverage for whitespace-only strings

The updated validation logic now rejects whitespace-only strings (e.g., ' '), but the existing tests in CategoryModelTest only cover completely empty strings ''. Adding test cases for whitespace-only inputs would ensure this bugfix is properly validated.

Example:

public function testWhitespaceOnlyCategoryId(): void
{
    $this->expectException(EmptyCategoryParameterException::class);
    new Category('   ', 'test');
}

[Copilot]

issue (blocking): Values validated with trim() but stored untrimmed creates data inconsistency

The validation checks trim($id) === '' but then stores the original $id value on line 39 without trimming. This means strings like " test " will pass validation but be stored with leading/trailing whitespace, creating inconsistent data.

Consider trimming the values before storing them:

$this->id = trim($id);
$this->name = trim($name);

[Copilot]

issue (blocking): Values validated with trim() but stored untrimmed creates data inconsistency

The validation checks trim($id) === '' and trim($name) === '' but then stores the original values on lines 39-40 without trimming. This means strings like " test " will pass validation but be stored with leading/trailing whitespace, creating inconsistent data.

Consider trimming the values before storing them:

$this->id = trim($id);
$this->name = trim($name);