Release v2.0.0 #15
Release v2.0.0 #15
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the v2.0.0 release by updating the sequra/integration-core dependency from release candidate to stable version and adding essential repository management and automation files.
- Updates
sequra/integration-corefrom^4.0.0@RCto stable^4.0.0version - Adds GitHub Actions workflow for automated Packagist notifications
- Introduces repository management files (CODEOWNERS, .gitattributes, PR template)
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Removes RC constraint from integration-core dependency, switching to stable v4.0.0 |
| composer.lock | Updates lock file with stable v4.0.0 version and removes stability flag |
| .github/workflows/packagist.yml | Adds automated workflow to notify Packagist on repository updates |
| .github/PULL_REQUEST_TEMPLATE.md | Introduces standardized PR template with sections for goals, implementation, testing, and deployment |
| .github/CODEOWNERS | Assigns repository ownership to @sequra/partnerships team |
| .gitattributes | Configures export-ignore rules to exclude development files from package distributions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Opportunistic refactorings | ||
|
|
||
| _Have you improved the code/app in anyway? Explain what you did._ |
There was a problem hiding this comment.
typo: Spelling error in "anyway". Should be "any way" (two words) when asking if something was improved in any manner.
| _Have you improved the code/app in anyway? Explain what you did._ | |
| _Have you improved the code/app in any way? Explain what you did._ |
| on: | ||
| push: |
There was a problem hiding this comment.
issue (blocking): The workflow triggers on every push to any branch, which could cause unnecessary Packagist updates and API rate limit issues. Consider limiting this to specific branches (e.g., main, master) or tags to ensure Packagist is only notified for actual releases.
| curl -XPOST -H 'Content-Type: application/json' \ | ||
| "https://packagist.org/api/update-package?username=sequra&apiToken=${{ secrets.PACKAGIST_API_TOKEN }}" \ | ||
| -d '{"repository":{"url":"https://github.com/sequra/integration-middleware"}}' |
There was a problem hiding this comment.
suggestion (non-blocking): The curl command lacks error handling. If the API call fails, the workflow will succeed silently. Consider adding the --fail flag to curl to ensure the workflow fails on HTTP errors, making failures visible in the Actions log.
What is the goal?
Release v2.0.0
How is it being implemented?
This pull request introduces several improvements to project configuration, developer workflow, and repository management. The main changes include the addition of export-ignore rules for packaging, a new CODEOWNERS file, a detailed pull request template, automation for updating Packagist, and an update to the
composer.jsondependency version constraint.Dependency management:
composer.jsondependency onsequra/integration-coreto use the stable^4.0.0version instead of the release candidate, improving stability.Opportunistic refactorings
Repository management and packaging:
.gitattributesto exclude development and configuration files from package exports, ensuring cleaner distribution archives.@sequra/partnershipsteam, improving code review and maintenance processes.Developer workflow improvements:
.github/PULL_REQUEST_TEMPLATE.mdto standardize PR submissions and ensure important information is included..github/workflows/packagist.yml) to automatically notify Packagist of updates on push, streamlining package publishing.How is it tested?
Automatic tests
How is it going to be deployed?
Standard deployment