widget doesn't load if "dest" is empty #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s empty fix "is not a valid css selector to write sequra widget to" if dest is empty
Author
|
@m1k3lm feel free to merge the change, if you consider it could work globally (it worked for us) |
m1k3lm
reviewed
Feb 20, 2019
Member
m1k3lm
left a comment
m1k3lm
left a comment
There was a problem hiding this comment.
Thanks for your feedback!
The aim of logging that error to the console was to rememenber the user to set a valid destination CSS selector. Might be the message is not as descriptive as it should.
Using source selector as default destination is not a bad idea for the partpayments widget, but the invoice widget will no fit well under the price.
Author
|
Ok @m1k3lm didn't know about that invoice widget ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "is not a valid css selector to write sequra widget to" if dest is empty