Updated Node versions in CI#587
Merged
jamesmbourne merged 1 commit intoserverless-heaven:masterfrom May 15, 2020
miguel-a-calles-mba:master
Merged
Updated Node versions in CI#587jamesmbourne merged 1 commit intoserverless-heaven:masterfrom miguel-a-calles-mba:master
jamesmbourne merged 1 commit intoserverless-heaven:masterfrom
miguel-a-calles-mba:master
Conversation
miguel-a-calles-mba
changed the title
j0k3r
approved these changes
May 15, 2020
miguel-a-calles-mba
requested review from
HyperBrain,
jamesmbourne and
rdsedmundo
jamesmbourne
approved these changes
May 15, 2020
Contributor
jamesmbourne
left a comment
jamesmbourne
left a comment
There was a problem hiding this comment.
LGTM! I think 10 and 12 is a sensible set of versions to support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Updated minimum node version in CI based on a recommendation in #570.
How did you implement it:
Updated the Travis and AppVeyor configurations.
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO