Skip to content

Error not properly rejected #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rifflock wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Error not properly rejected #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions CF/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
* Retrieve CloudFormation information within a lambda.
*/

var Promise = require('bluebird'),
var BbPromise = require('bluebird'),
AWS = require('aws-sdk');

var cloudformation = new AWS.CloudFormation({apiVersion: '2010-05-15', region: process.env.SERVERLESS_REGION });

var CF = {
};

Expand All @@ -15,47 +17,45 @@ var CF = {
CF.loadVars = function () {
// Build CF stack name
if ((!process.env.SERVERLESS_PROJECT_NAME || !process.env.SERVERLESS_STAGE || !process.env.SERVERLESS_REGION)) {
return Promise.reject(new Error("Serverless environment not set"));
return BbPromise.reject(new Error("Serverless environment not set"));
}

var stackName = process.env.SERVERLESS_PROJECT_NAME + "-" + process.env.SERVERLESS_STAGE + "-r";
return CF._describeCFStack(stackName)
.then(function(stackDescription) {
if (!stackDescription.hasOwnProperty('Outputs') || stackDescription.Outputs.constructor !== Array) {
return Promise.reject(new Error("No outputs in stack description"));
return BbPromise.reject(new Error("No outputs in stack description"));
}

return Promise.each(stackDescription.Outputs, function (outVar) {
return BbPromise.each(stackDescription.Outputs, function (outVar) {
process.env["SERVERLESS_CF_" + outVar.OutputKey] = outVar.OutputValue;
return null;
});
})
.catch(function (err) {
console.log("WARN: Error retrieving CF variables");
return Promise.reject(err);
return BbPromise.reject(err);
});
};

/**
* Get the CF stack description
*/
CF._describeCFStack = function(stackName) {
return new Promise(function(resolve,reject) {
var cloudformation = new AWS.CloudFormation({apiVersion: '2010-05-15', region: process.env.SERVERLESS_REGION });

return new BbPromise(function(resolve,reject) {
cloudformation.describeStacks({ StackName: stackName }, function(err, data) {
if (err) {
reject(err);
return reject(err);
}

if (!data || !data.Stacks || data.Stacks.constructor !== Array || data.Stacks.length === 0) {
reject(new Error("invalid response", data));
return reject(new Error("invalid response", data));
}

// Return only the stack description
resolve(data.Stacks[0]);
return resolve(data.Stacks[0]);
});
})
});
};

module.exports = CF;