-
Notifications
You must be signed in to change notification settings - Fork 12
build: Convert to workspace monorepo #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
===========================================
- Coverage 91.97% 27.95% -64.03%
===========================================
Files 97 87 -10
Lines 3728 3291 -437
Branches 1904 1735 -169
===========================================
- Hits 3429 920 -2509
- Misses 299 2371 +2072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cd07d89 to
3c44e45
Compare
0144273 to
1285f38
Compare
37ef978 to
19b14d4
Compare
19b14d4 to
de84be2
Compare
Move from flat single-package structure to multi-package monorepo: - packages/relic_core: Core framework (platform-agnostic) - packages/relic_io: dart:io adapter and static file handler - packages/relic: Main package that re-exports core and io - packages/benchmark: Router benchmarks - packages/examples: Example applications Uses Dart workspace feature with melos for package management.
de84be2 to
7c2cc98
Compare
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
|
@marcelomendoncasoares Disregard the coverage check. Codecov doesn't track this restructure correctly. |
marcelomendoncasoares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Only two small suggestions/discussions about the best way to deal with documentation for the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postponing the CHANGELOG and REDME separation, changes LGTM! 🚀
As a side note from the discussion, I would only suggest explaining the role of relic_core and relic_io on the README, so that contributors can easily know where is more appropriate for each kind of change.
Description
Restructures the repository into a multi-package workspace.
Other changes:
Closes: #275
Pre-Launch Checklist
///), ensuring consistency with existing project documentation.Breaking Changes
Breaking changes:
package:relic/src/...will need to update importspackage:relic/io_adapter.dartis nowpackage:relic_io/relic_io.dartAdditional Notes
This is a structural refactor only. No functional changes to the framework behavior. Users importing from
package:relic/relic.dartshould not need any code changes.