Skip to content

Conversation

@cmrschwarz
Copy link
Contributor

@cmrschwarz cmrschwarz commented Mar 14, 2025

This PR allows the pathfinder workspace to compile and pass all tests on Linux again.

I find it very helpful to be able to run cargo test --all in a workspace just to check if I broke anything.

There were three main issues preventing this:

  1. The canvas_metal_minimal example expects to link against metal specific APIs:
    I disabled this example on non-apple platforms in a way that's similar to how other projects like rust-skia do this.

  2. The android demo had some minor inconsistencies (seems to not have been compiled in a while ... ;)),
    so I fixed those.

  3. The Magic Leap demo is pretty fundamentally broken. It uses nonexistant APIs and expects to call into many now private internals.
    I decided to comment out it's member entry in the root workspace.
    Since the hardware it was written for seems to be no longer usable, even for preexisting owners, I was hoping this would be an acceptable tradeoff. It certainly does not seem to make things worse.

With these 3 small changes you can now cargo test --all and cargo build --all the project on Linux again.

@cmrschwarz cmrschwarz changed the title Fix compilation errors Fix Linux Build Mar 14, 2025
Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all reasonable choices. Thanks!

@jdm jdm enabled auto-merge March 16, 2025 21:06
@jdm jdm added this pull request to the merge queue Mar 16, 2025
Merged via the queue into servo:main with commit 9dc1dd9 Mar 16, 2025
2 checks passed
@cmrschwarz
Copy link
Contributor Author

Awesome, thanks <3.

I know this project has went through a bit of a rough patch, but I still find it very useful even in its current state.

Is there any chance we could get the pathfinder_webgl and maybe even pathfinder (pontuslaestadius/pathtracer#41) crates released on crates io @jdm?

I would be happy to help out with any of the necessary work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants