Skip to content

Conversation

@ThomasSession
Copy link
Collaborator

@ThomasSession ThomasSession commented Dec 18, 2025

Networking refactor: Separation of concerns, error management, path/snodepool/swarm management, recovery strategies.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth to invest in writing unit test for this class, it seems like a good candidate to do so

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In junit test, we normally use the test rules to do thing like this. Instead of forcing the test suit to extend from a concrete class, it's more flexible to use a test rule instead. Like this:

class PathManagerTest {
   @get:Rule
   val logRule = MockLoggingRule() // We actually have an existing rule to set up the mock logging

    @Test
    fun myTest() {}
}

@ThomasSession ThomasSession merged commit 300601e into dev Jan 14, 2026
4 checks passed
@ThomasSession ThomasSession deleted the feature/onion-request-refactor branch January 14, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants