-
Notifications
You must be signed in to change notification settings - Fork 55
Feature/onion request refactor #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth to invest in writing unit test for this class, it seems like a good candidate to do so
* Remove PushRegistryV1 as it is for legacy group only * Clean up push registration retry logic * Comments * Asserting API contract
…ession-foundation/session-android into feature/onion-request-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In junit test, we normally use the test rules to do thing like this. Instead of forcing the test suit to extend from a concrete class, it's more flexible to use a test rule instead. Like this:
class PathManagerTest {
@get:Rule
val logRule = MockLoggingRule() // We actually have an existing rule to set up the mock logging
@Test
fun myTest() {}
}
Networking refactor: Separation of concerns, error management, path/snodepool/swarm management, recovery strategies.