-
Notifications
You must be signed in to change notification settings - Fork 5
feat: use session localization git submodule #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the project to use a git submodule for session localization instead of maintaining localization files directly in the repository. The change introduces a new submodule at run/localizer/lib and updates the Node.js version requirement from 18 to 24.
Key Changes:
- Replaced inline localization files with a git submodule reference
- Updated Node.js version from 18 to 24 across configuration files
- Modified GitHub Actions workflows to checkout submodules recursively
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
run/localizer/locales.ts |
Removed entire localization dictionary file (5675 lines) to be replaced by submodule |
run/localizer/lib |
Added git submodule reference pointing to session-foundation/session-localization repository |
run/localizer/englishStrippedStr.ts |
Updated import to reference localization from the new submodule lib |
run/localizer/constants.ts |
Removed constants file (likely moved to submodule) |
run/localizer/Localizer.ts |
Removed localization utility file (512 lines, likely moved to submodule) |
package.json |
Updated @types/node from ^20.14.10 to 24 and node engine requirement from >=18 to >=24 |
yarn.lock |
Updated @types/node and undici-types dependency versions to align with Node.js 24 |
.tool-versions |
Added file specifying node 24.12.0 |
.nvmrc |
Updated Node.js version from 18.15.0 to 24.12.0 |
.mise.toml |
Added configuration file specifying yarn version 4 |
.gitmodules |
Added submodule configuration for session-localization |
README.md |
Updated setup instructions to include git lfs and submodule initialization steps |
.github/workflows/*.yml |
Added submodules: 'recursive' to all checkout actions in workflow files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.