Skip to content

Conversation

@Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Jan 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 9, 2026 02:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a step to install system-level dependencies (libcurl4-openssl-dev, build-essential, and python3) required for building native Node.js modules in the CI environment.

  • Adds a new step to install Linux system dependencies for native module compilation
  • Placed before the "Install yarn" step in the setup action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

with:
node-version-file: '.nvmrc'

- name: Install dependencies for native modules
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new step is missing the required 'shell' specification. In composite actions, every step that uses 'run' must explicitly specify a shell. Add 'shell: bash' to be consistent with the other steps in this action.

Suggested change
- name: Install dependencies for native modules
- name: Install dependencies for native modules
shell: bash

Copilot uses AI. Check for mistakes.
with:
node-version-file: '.nvmrc'

- name: Install dependencies for native modules
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is described as "Setup environment for both platforms" and is used by both iOS (macOS runners) and Android (Linux runners) workflows. However, this step uses Linux-specific package management (apt-get) which will fail on macOS runners. Consider adding a conditional to only run this step on Linux runners, or check the OS before executing.

Suggested change
- name: Install dependencies for native modules
- name: Install dependencies for native modules
if: runner.os == 'Linux'

Copilot uses AI. Check for mistakes.

- name: Install dependencies for native modules
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev build-essential python3

Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace at the end of this line. Remove the trailing spaces to maintain consistency with the codebase.

Suggested change

Copilot uses AI. Check for mistakes.
@Aerilym Aerilym merged commit 66f7f0a into session-foundation:dev Jan 9, 2026
1 check passed
@Aerilym Aerilym deleted the fix/ci branch January 9, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant