feat: add desktop localization codegen #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
approved these changes
Jan 7, 2026
Bilb
approved these changes
Jan 7, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Python code generator for Session Desktop localization files, replacing the previous string generation approach. The new script generates TypeScript type definitions and translations in a sparse format (only actual translations, no English duplicates).
- Adds
codegen_desktop.pyto generate TypeScript localization files with type safety - Updates GitHub Actions workflow to use the new code generator
- Changes output structure to generate files under
ts/localization/generated/
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| crowdin/codegen_desktop.py | New Python script that generates TypeScript localization files (locales.ts, english.ts, translations.ts, constants.ts) with type definitions and sparse translations |
| .github/workflows/check_for_crowdin_updates.yml | Updated workflow to call the new codegen script instead of the old string generator, removed Desktop checkout step, and updated artifact paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
approved these changes
Jan 7, 2026
Bilb
approved these changes
Jan 8, 2026
mpretty-cyro
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop changes: session-foundation/session-desktop#1761