Improved the ontologic reasonner#6
Open
alexis-jacq wants to merge 1 commit intoseverin-lemaignan:masterfrom
Open
Improved the ontologic reasonner#6alexis-jacq wants to merge 1 commit intoseverin-lemaignan:masterfrom
alexis-jacq wants to merge 1 commit intoseverin-lemaignan:masterfrom
Conversation
Owner
|
Thanks for this PR! I do see some issues with it, though, reported above. |
Owner
|
Ok, thanks. Before reviewing, could you please rebase on master. |
Owner
|
Ok, the tests pass! cool. Thanks for the improvements. I let you comment/beautify the code before merging. |
The get_missig_taxonomy_stmts method was not complete, a lot of possible deductions was neglected because 1) dynamic onto classes was not updated inside recursives iterations 2) it didn't return new equivalent classes Added tests (test_reason.py) to bring out the importance of this improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_missig_taxonomy_stmts method was not complete, a lot of possible deductions was neglected because 1) dynamic onto classes was not updated with recursive iterations 2) it didn't return new equivalent classes