Conversation
with servicemonitor prometheus will be able to discover the metrics exposed on the pod.
|
Hello, I'd be happy to get some feedback, while I can still have my hand into this at work. Best |
|
PING |
|
@bmm-alc, can you solve the merge conflicts? |
| selector: | ||
| matchLabels: | ||
| {{- include "sftpgo.selectorLabels" . | nindent 6 }} |
There was a problem hiding this comment.
There's no way to differentiate between the built-in .service and the extra .services.* on labels only.
I think we need to add labels to differentiate them and select only the internal service.
| {{- if .Values.monitoring.enabled }} | ||
| - name: telemetry | ||
| port: 10000 | ||
| targetPort: telemetry | ||
| protocol: TCP | ||
| {{- if semverCompare ">=1.20-0" .Capabilities.KubeVersion.GitVersion }} | ||
| appProtocol: http | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
We should add the same if {{- if .Values.monitoring.enabled }} in the deployment telemetry env vars.
| labels: | ||
| {{- include "sftpgo.labels" . | nindent 4 }} | ||
| {{- with .Values.service.annotations }} | ||
| annotations: | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Missing ServiceMonitor exclusive labels and annotations
@lucasfcnunes I'm sorry but at the moment I don't have the time to properly review and test this change. Also, our CI is currently broken (see #33). Any help would be appreciated. Thank you |
3 participants
with servicemonitor prometheus will be able to discover the metrics exposed on the pod.