docs: align README/features CLI examples with args.py#29
Open
Taskrwu wants to merge 1 commit intosgl-project:mainfrom
Open
docs: align README/features CLI examples with args.py#29Taskrwu wants to merge 1 commit intosgl-project:mainfrom
Taskrwu wants to merge 1 commit intosgl-project:mainfrom
Conversation
Collaborator
|
Thanks. Actually Python argparse allows abbreviation for arguments, so simply passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistencies between documentation examples and the actual CLI argument names defined in
python/minisgl/server/args.py.Changes:
README.md: Updated--model~--model-path,--tp~--tp-size,--shell~--shell-mode,--cache~--cache-typedocs/features.md: Same parameter name updates, plus a note about--attnCLI limitationNo code changes, documentation only. All examples should now work when copy-pasted.