feat: - add telegram data validation #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saniok017
requested review from
PavloKovalov,
artur-code,
dasnein and
dmitry-sidorov
artur-code
requested changes
Jun 16, 2019
server/lib/dataValidation.js
Outdated
| } | ||
| if (+new Date() - user.auth_date > 86400) { | ||
|
|
||
| if (+new Date() / 1000 - user.auth_date > 86400) { |
Collaborator
There was a problem hiding this comment.
86400 претендует на константу или даже сеттинг
server/api/apiAuth.js
Outdated
| }) | ||
| .catch(err => console.log(err)); | ||
| }); | ||
| let { department } = user || null; |
Collaborator
There was a problem hiding this comment.
|| null избыточен, так как если department нету в user то он будет undefined что вполне ожидаемо так как undefined именно вычисляемый тип, по сути department мы вычисляем а не декларируем со значением по умолчанию null
server/api/apiAuth.js
Outdated
| .all(dataValidation) | ||
| .post((req, res) => { | ||
| const reqUser = req.body; | ||
| const DBController = new ClassDBController('user', 'department'); |
Collaborator
There was a problem hiding this comment.
В этом месте лучше подойдет нэйминг вида userDBController вместо DBController так далее в программе будет понятней что мы оперируем не каким то супер контролером всех сущностей
Collaborator
Author
There was a problem hiding this comment.
лучше использовать развернутое описание
userDepartmentDBController
или достаточно
userDBController ❓
Collaborator
Author
|
Благодарю 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if data is from the telegram