fix(KRYT-1): replace delete with free for malloc'd _image buffer#8
Open
tapiau wants to merge 1 commit intosheffieldhackspace:mainfrom
Open
fix(KRYT-1): replace delete with free for malloc'd _image buffer#8tapiau wants to merge 1 commit intosheffieldhackspace:mainfrom
tapiau wants to merge 1 commit intosheffieldhackspace:mainfrom
Conversation
_image is allocated with malloc() but was freed with delete, which is undefined behaviour in C++. Replace with free() for correct pairing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
are you going to write a hit piece on me if i don't merge this |
Author
|
No, it doesn’t really matter - one of these days I’ll grab couple of cans of Guinness 0.0 and drop by to meet you guys anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_image is allocated with malloc() but was freed with delete, which is undefined behaviour in C++. Replace with free() for correct pairing.