Skip to content

remove extra space before , in cast list; tweak link underline css #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam-shift72 merged 3 commits into from
Sep 17, 2025
Merged

remove extra space before , in cast list; tweak link underline css #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
351e2f9
remove extra space before , in cast list
sam-shift72 Sep 17, 2025
6fd5cab
meta detail links: tone down the underline a bit
sam-shift72 Sep 17, 2025
82fe843
changelog
sam-shift72 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased](https://github.com/shift72/core-template/compare/1.9.27...HEAD)

### Changed

- Cast list: remove erroneous space before comma. CSS tweaks for the link underlines

## [1.9.27](https://github.com/shift72/core-template/compare/1.9.26...1.9.27)

### Changed
Expand Down
3 changes: 3 additions & 0 deletions site/styles/_meta-detail.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,9 @@ s72-element-switcher,
a {
animation: fadein 2s;

text-decoration-color: rgba(var(--body-color-rgb), 0.5);
text-underline-offset: 0.1em;

&:hover {
text-decoration: none;
}
Expand Down
3 changes: 1 addition & 2 deletions site/templates/film/item.jet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,7 @@
{{range index, member := film.Cast}}
{{ path := "/search.html?q=" + member.Name }}
{{ showCharacter := !isEnabled("site_hide_cast_character_name")}}
<a href="{{ routeToPath(path) }}">{{member.Name}}</a>{{if len(member.Character) > 0 && showCharacter}}<span class="meta-detail-character"> ({{member.Character}})</span>{{end}}
{{if index < len(film.Cast) - 1}}, {{end}}
<a href="{{ routeToPath(path) }}">{{member.Name}}</a>{{if len(member.Character) > 0 && showCharacter}}<span class="meta-detail-character"> ({{member.Character}})</span>{{end}}{{if index < len(film.Cast) - 1}}, {{end}}
{{end}}
</p>
</div>
Expand Down