Add raw Gyro input for additional camera controls#209
Open
BlackJohn07 wants to merge 1 commit intoshiiion:primehack-masterfrom
Open
Add raw Gyro input for additional camera controls#209BlackJohn07 wants to merge 1 commit intoshiiion:primehack-masterfrom
BlackJohn07 wants to merge 1 commit intoshiiion:primehack-masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using controller gyroscope capabilities for PrimeHack's camera (without an external program) is possible only through Dolphin's input expression system. This method however has the following drawbacks:
This feature branch proposes to add a new input group, which can be used in conjunction with the camera stick while in "Controller Mode", and is configurable from each of the PrimeHack-controller settings windows. This group makes use of Dolphin's pre-existing
IMUGyroscopeclass, requiring no custom logic for dealing with this type of input. The group is extended with three additional properties:Horizontal Sensitivitysetting - direct scaling factor for yaw rotationsVertical Sensitivitysetting - direct scaling factor for pitch rotationsActivateinput slot - definable button that, while held, activates gyro camera controlThe group can also be disabled or enabled in its entirety through a new setting in the camera stick's control group.
Note:
For better clarification, the PrimeHack camera stick control group has been internally renamed from
Camera ControltoPrimeHack CameraStick, as it is now paired withPrimeHack CameraGyro. Switching from the current PrimeHack version, users would have to reconfigure their stick settings or update the existing INI file to import previous stick settings.Further Note:
While the set of changed files for this feature is kept minimal, most files that are affected where also touched upon with minor fixes and refactors disjointed from the feature (e.g. use of the i18n
_transmacro for a variable). In particular, almost every PrimeHack interface inGCPad.handWiimote.hnow takes in the controller port number as a parameter, so as to be more consistent with the remaining baseline Dolphin code. The UI code has also become observably more concise because of this. Should these disjointed changes impede the decision to merge this branch, a new branch with only feature-related changes can be made.