Merged
Conversation
j-f-ox
approved these changes
Apr 15, 2025
Collaborator
j-f-ox
left a comment
j-f-ox
left a comment
There was a problem hiding this comment.
Great work cleaning up proofs and adding the new features 👍
| IsWellFormedTy T1 -> | ||
| HasTy Γ t1 T1 -> | ||
| HasTy (T1 :: Γ) t2 T2 -> | ||
| HasTy Γ (Term.bind t1 t2) T2 |
Collaborator
There was a problem hiding this comment.
Just out of curiosity, why do we need T1 to be well-formed but not T2?
Owner
Author
There was a problem hiding this comment.
In theory we could sprinkle IsWellFormedTy on every type. But in practice IsWellFormedTy is implied for other types since they are mentioned in the constructor (HasTy Γ (Term.bind t1 t2) T2, T1 does not appear here so it is not implied to be wellformed, hence it needs to be added to assumptions).
Maybe I should add a HasTy implies IsWellFormedTy theorem just to make sure we have this property?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.