thunar: Selected sidepane item when disabled should not stand out#348
Open
andreldm wants to merge 2 commits intoshimmerproject:masterfrom
Open
thunar: Selected sidepane item when disabled should not stand out#348andreldm wants to merge 2 commits intoshimmerproject:masterfrom
andreldm wants to merge 2 commits intoshimmerproject:masterfrom
Conversation
houndci-bot
reviewed
Jun 17, 2024
Contributor
Author
|
@bluesabre @ochosi can I drag you guys back to review this PR? 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Thunar is not focused, the selected item in the sidepane is not grayed out, this is not really perceptible because only the label text remains black-ish, when symbolic icons (new feature, behind a hidden toggle) are used this glitch is more prominent.
This PR fixes only Thunar's sidepane, 1. because I couldn't make this a generic style adjustment in
_commons.scss, 2. because I'm afraid it could cause regressions.The icon theme used in the screenshots below is Papirus.