support measuring peak memory usage on mac#11
Open
rszymanski wants to merge 1 commit intoshinra-dev:masterfrom
Open
support measuring peak memory usage on mac#11rszymanski wants to merge 1 commit intoshinra-dev:masterfrom
rszymanski wants to merge 1 commit intoshinra-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for making this package!
I have noticed that measuring peak memory usage on macOS is not yet supported. I think I figured out a way how to achieve that.
Let me know if there is anything else I should include in the Pull Request!
Change Description
Adds support for measuring peak memory usage on macOS using the MACH API.
The solution was inspired by this Stack Overflow thread.
How I checked if it is measuring peak memory usage correctly
I compared it with the output of
/usr/bin/timewhich also measures peak memory usage.Here is the R script I used for testing:
And here is the output of
/usr/bin/time -l Rscript test_memuse.RThe
maximum resident set sizereported by/usr/bin/timematches the peak memory usage reported bymemuse.