Add test for decreasing fillValue animation#145
Add test for decreasing fillValue animation#145Copilot wants to merge 4 commits intoanimation-fixfrom
Conversation
Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
|
@copilot, I just merged a PR to my base branch. Check if these tests are still actual or no longer needed |
Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
I checked the base branch and found that PR #144 was merged, which changed the animation behavior from blocking to cancellation. I've updated the PR to:
The PR now adds only one meaningful test: verifying that animations work correctly when fillValue decreases. Commit: 0db82f0 |
|
@copilot please update the pr and verify if these tests are still needed, if not please close th PR. |
After checking the current state of the base branch ( What the base branch has:
What this PR uniquely adds:
The two previously redundant tests (blocking/completion behavior) were already removed in commit 0db82f0. The remaining test genuinely fills a gap in coverage by verifying the decreasing direction — since the base only tests the increasing case, it's possible a regression could slip through for decreasing values. If you'd prefer not to merge this test at all, the PR can be closed. Otherwise the single test it adds is still valid and passes. |
|
@copilot resolve conflicts |
Conflicts resolved. The branch now cleanly merges into |
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.