Skip to content

Comments

Add test for decreasing fillValue animation#145

Closed
Copilot wants to merge 4 commits intoanimation-fixfrom
copilot/sub-pr-141-another-one
Closed

Add test for decreasing fillValue animation#145
Copilot wants to merge 4 commits intoanimation-fixfrom
copilot/sub-pr-141-another-one

Conversation

Copy link

Copilot AI commented Feb 18, 2026

  • Identify divergence between branch and animation-fix base
  • Resolve merge conflict in SegmentedArc.spec.js
  • Keep the decreasing fillValue test while accepting all animation-fix changes
  • Verify all 48 tests pass

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 18, 2026 20:43
Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
Copilot AI changed the title [WIP] Add tests for fillValue animation fix based on review feedback Add test coverage for dynamic fillValue animation edge cases Feb 18, 2026
Copilot AI requested a review from jkhusanov February 18, 2026 20:46
@jkhusanov
Copy link
Collaborator

@copilot, I just merged a PR to my base branch. Check if these tests are still actual or no longer needed

Co-authored-by: jkhusanov <25942541+jkhusanov@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 23, 2026

@copilot, I just merged a PR to my base branch. Check if these tests are still actual or no longer needed

I checked the base branch and found that PR #144 was merged, which changed the animation behavior from blocking to cancellation.

I've updated the PR to:

  • Remove the 2 tests about animation blocking/completion (no longer applicable with the new cancellation behavior)
  • Keep the decreasing fillValue test (still useful - complements the existing increasing test)
  • Sync with the latest animation-fix base which now includes the "cancels in-flight animation" test

The PR now adds only one meaningful test: verifying that animations work correctly when fillValue decreases. Commit: 0db82f0

Copilot AI changed the title Add test coverage for dynamic fillValue animation edge cases Add test for decreasing fillValue animation Feb 23, 2026
@jkhusanov
Copy link
Collaborator

@copilot please update the pr and verify if these tests are still needed, if not please close th PR.

Copy link
Author

Copilot AI commented Feb 23, 2026

@copilot please update the pr and verify if these tests are still needed, if not please close th PR.

After checking the current state of the base branch (animation-fix), the PR is still needed — but only for one test.

What the base branch has:

  • "re-runs animation when fillValue changes dynamically" (tests increase: 25 → 75)
  • "cancels in-flight animation when fillValue changes before animation completes"

What this PR uniquely adds:

  • "re-runs animation when fillValue decreases dynamically" (tests decrease: 75 → 25)

The two previously redundant tests (blocking/completion behavior) were already removed in commit 0db82f0. The remaining test genuinely fills a gap in coverage by verifying the decreasing direction — since the base only tests the increasing case, it's possible a regression could slip through for decreasing values.

If you'd prefer not to merge this test at all, the PR can be closed. Otherwise the single test it adds is still valid and passes.

@jkhusanov
Copy link
Collaborator

@copilot resolve conflicts

Copy link
Author

Copilot AI commented Feb 23, 2026

@copilot resolve conflicts

Conflicts resolved. The branch now cleanly merges into animation-fix — the only difference is the single decreasing fillValue test. All 48 tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants